Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to chalk 5.0 #10

Closed
wants to merge 1 commit into from

Conversation

bartlomieju
Copy link

@bartlomieju bartlomieju commented Jan 9, 2022

Trying to run tap (with treport) in Deno's compatibility mode I hit a problem caused by chalk at ^3.0.0; at that point in time chalk relied on Object.prototype.__proto__, which is not supported in Deno. This upgrade fixes the problem.

Ref denoland/deno#13321

@isaacs
Copy link
Member

isaacs commented Jul 4, 2022

This breaks every test.

lib/reports/terse/log.test.jsx 2> /Users/isaacs/dev/tapjs/treport/lib/reports/base/index.js:64
lib/reports/terse/log.test.jsx 2> 
lib/reports/terse/log.test.jsx 2>    ^
lib/reports/terse/log.test.jsx 2> 
lib/reports/terse/log.test.jsx 2> Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/isaacs/dev/tapjs/treport/node_modules/chalk/source/index.js from
/Users/isaacs/dev/tapjs/treport/lib/reports/base/index.js not supported.
lib/reports/terse/log.test.jsx 2> Instead change the require of /Users/isaacs/dev/tapjs/treport/node_modules/chalk/source/index.js in
/Users/isaacs/dev/tapjs/treport/lib/reports/base/index.js to a dynamic import() which is available in all CommonJS modules.

@bartlomieju
Copy link
Author

Sorry, this was not needed after all; I forgot to close the PR.

@bartlomieju bartlomieju closed this Jul 4, 2022
@bartlomieju bartlomieju deleted the upgrade_chalk branch July 4, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants